Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add parameters for pager to device_credentials method #318

Merged
merged 1 commit into from
Feb 28, 2022
Merged

Add parameters for pager to device_credentials method #318

merged 1 commit into from
Feb 28, 2022
+25 −2

Conversation

shibayu36
Copy link
Contributor

@shibayu36 shibayu36 commented Feb 18, 2022 •
edited
Loading

Changes

I added page, per_page, include_totals parameters to device_credentials method, because API documents describe that Retrieve device credentials API has parameters for pagerize.

References

No References

Testing

Please describe how this can be tested by reviewers. Be specific about anything not tested and reasons why. If this library has unit and/or integration testing, tests should be added for new functionality and existing tests should complete without errors.

  • This change adds unit test coverage
  • This change adds integration test coverage
  • This change has been tested on the latest version of Ruby

Checklist

  • I have read the Auth0 general contribution guidelines
  • I have read the Auth0 Code of Conduct
  • All existing and new tests complete without errors
  • Rubocop passes on all added/modified files
    • I found some offenses by rubocop in lib/auth0/api/v2/device_credentials.rb and spec/lib/auth0/api/v2/device_credentials_spec.rb. But I left it at that because there were originally many offenses
  • All active GitHub checks have passed

@shibayu36 shibayu36 marked this pull request as ready for review February 18, 2022 06:00
@shibayu36 shibayu36 requested a review from a team as a code owner February 18, 2022 06:00
@shibayu36 shibayu36 force-pushed the device-credentials-paging branch from 9074288 to 56e7d1c Compare February 18, 2022 10:31
@shibayu36 shibayu36 changed the title Add page and per_page parameters to device_credentials method Add parameters for pager to device_credentials method Feb 18, 2022
stevehobbsdev
stevehobbsdev approved these changes Feb 18, 2022
View reviewed changes
Copy link
Contributor

@stevehobbsdev stevehobbsdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great - thanks for the contribution!

@stevehobbsdev stevehobbsdev added this to the vNext milestone Feb 18, 2022
@shibayu36
Copy link
Contributor Author

What should I do next to merge this pull request? I am going to make a next pull request, but it may be conflict if I make it before this PR is merged.

@stevehobbsdev stevehobbsdev merged commit e0b6216 into auth0:master Feb 28, 2022
@stevehobbsdev
Copy link
Contributor

Thanks @shibayu36 , have merged 👍🏻

@shibayu36
Copy link
Contributor Author

Thanks to merge! I will create a next pull request later.

@shibayu36 shibayu36 deleted the device-credentials-paging branch March 4, 2022 07:48
@shibayu36
Copy link
Contributor Author

@stevehobbsdev When do you plan to release a next version? I would like to use device_credentials fixed by this PR and #321

If there is something that I need to do to release, feel free to let me know.

@stevehobbsdev
Copy link
Contributor

All good @shibayu36, I will be cutting a release by the end of the week 👍🏻

@stevehobbsdev stevehobbsdev mentioned this pull request Mar 25, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stevehobbsdev stevehobbsdev stevehobbsdev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
vNext
Development

Successfully merging this pull request may close these issues.
2 participants
@shibayu36 @stevehobbsdev